add huffman encoding in go #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation
zsparal
suggested changes
Oct 9, 2018
| } | ||
|
|
||
| for len(nodeList) > 1 { | ||
| sort.Slice(nodeList, func(i, j int) bool { |
There was a problem hiding this comment.
This basically destroys the algorithmic complexity of Huffman-encoding. We could either use container/heap or roll our own version of it (a heap is pretty easy to implement and it could avoid having to cast back from interface).
| } | ||
|
|
||
| // 0x30 == "0" and 0x31 == "1" | ||
| code = append(code, 0x30) |
There was a problem hiding this comment.
Why not just use '0' and '1'?
zsparal
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiled with
go version go1.11 linux/amd64and without errors